pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Andres Freund <andres@anarazel.de>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Backpatch addition of wait_for_log(), pump_until().
Date: Fri, 6 May 2022 15:29:43 +0200
Message-ID: <18b37361-b482-b9d8-f30d-6115cd5ce25c@enterprisedb.com> (raw)
In-Reply-To: <E1nlh4S-002GQ0-Da@gemulon.postgresql.org>
References: <E1nlh4S-002GQ0-Da@gemulon.postgresql.org>

On 03.05.22 03:11, Andres Freund wrote:
> Backpatch addition of wait_for_log(), pump_until().
> 
> These were originally introduced in a2ab9c06ea1 and a2ab9c06ea1, as they are
> needed by a about-to-be-backpatched test.

I see this warning:

Subroutine pump_until redefined at t/013_crash_restart.pl line 246.

(There are a varying number of these warnings across the backbranches.)

Also, the local definition has different arguments than the backpatched 
one.  This should be double-checked.





view thread (7+ messages)  latest in thread

Message-ID: <18b37361-b482-b9d8-f30d-6115cd5ce25c@enterprisedb.com>
Permalink:  ../18b37361-b482-b9d8-f30d-6115cd5ce25c@enterprisedb.com/
Also on:    postgresql.org/message-id/18b37361-b482-b9d8-f30d-6115cd5ce25c@enterprisedb.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter.eisentraut@enterprisedb.com, andres@anarazel.de
  Subject: Re: pgsql: Backpatch addition of wait_for_log(), pump_until().
  In-Reply-To: <18b37361-b482-b9d8-f30d-6115cd5ce25c@enterprisedb.com>
  References: <E1nlh4S-002GQ0-Da@gemulon.postgresql.org> <18b37361-b482-b9d8-f30d-6115cd5ce25c@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox