From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove win32ver.rc from version_stamp.pl
Date: Tue, 10 Mar 2020 10:49:05 -0400
Message-ID: <19048.1583851745@sss.pgh.pa.us> (raw)
In-Reply-To: <50ecb345-4dc5-1f7d-64ca-7018195fcc8d@2ndquadrant.com>
References: <E1jBc1e-0006Yd-MY@gemulon.postgresql.org>
<50ecb345-4dc5-1f7d-64ca-7018195fcc8d@2ndquadrant.com>
Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> This created some seemingly unrelated build farm failures. I suspect
> this must have something to do with the new shell code in configure
> +PG_MINORVERSION=`expr "$PACKAGE_VERSION" : '.*\.\([0-9][0-9]*\)'`
> +test -n "$PG_MINORVERSION" || PG_MINORVERSION=0
> ending up with some nonsense being assigned to PG_MINORVERSION, perhaps
> due to a not-quite-mainstream Bourne shell being used.
Looking at the configure log on gharial, the only incorrect symbol
seems to be PG_VERSION_NUM:
#define PG_MAJORVERSION "13"
#define PG_MAJORVERSION_NUM 13
#define PG_MINORVERSION_NUM 0
#define PG_VERSION "13devel"
#define PG_VERSION_STR "PostgreSQL 13devel on ia64-hp-hpux11.31, compiled by gcc (GCC) 4.6.0, 64-bit"
#define PG_VERSION_NUM
which squares with the compile error that's being thrown (it's pointing at
a macro that uses PG_VERSION_NUM).
I'd suggest reverting the change in how PG_VERSION_NUM is computed
in configure.in --- that was certainly not necessary to the patch,
and evidently you're falling foul of some weird behavior around
nesting double-quotes and backquotes.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove win32ver.rc from version_stamp.pl
In-Reply-To: <19048.1583851745@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox