From: Tom Lane <tgl@sss.pgh.pa.us>
To: Christoph Berg <myon@debian.org>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Build src/port files as a library with -fPIC, and use that in li
Date: Fri, 28 Sep 2018 09:13:56 -0400
Message-ID: <19404.1538140436@sss.pgh.pa.us> (raw)
In-Reply-To: <20180928115830.GC26142@msg.df7cb.de>
References: <E1g5Y8r-0006vs-QA@gemulon.postgresql.org>
<20180928115830.GC26142@msg.df7cb.de>
Christoph Berg <myon@debian.org> writes:
> Re: Tom Lane 2018-09-27 <E1g5Y8r-0006vs-QA@gemulon.postgresql.org>
>> Build src/port files as a library with -fPIC, and use that in libpq.
> This made the "pqsignal" symbol disappear from libpq5.so:
Oh, interesting. I'd seen an actual error on prairiedog, but apparently
some other linkers just silently omit the export, if the symbol is in
a .a file rather than .o.
> Is this is a problem for libpq5 users?
I proposed in
https://www.postgresql.org/message-id/19581.1538077716@sss.pgh.pa.us
that we should remove pqsignal, as well as
pg_utf_mblen
pg_encoding_to_char
pg_char_to_encoding
pg_valid_server_encoding
pg_valid_server_encoding_id
from libpq's exports, on the grounds that (a) nobody should be using
those (they're undocumented as exports), and (b) anybody who is using
them should get them from libpgport/libpgcommon instead. Thoughts?
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, myon@debian.org, pgsql-hackers@postgresql.org
Subject: Re: pgsql: Build src/port files as a library with -fPIC, and use that in li
In-Reply-To: <19404.1538140436@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox