pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Straighten include order in guc-file.l
3+ messages / 3 participants
[nested] [flat]

* pgsql: Straighten include order in guc-file.l
@ 2022-11-03 05:39  John Naylor <john.naylor@postgresql.org>
  0 siblings, 1 reply; 3+ messages in thread

From: John Naylor @ 2022-11-03 05:39 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Straighten include order in guc-file.l

Oversight in dac048f71eb

Michael Paquier

Reviewed by Julien Rouhaud
Discussion: https://www.postgresql.org/message-id/Y2IATvRGo347Lvd1%40paquier.xyz

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/062eef3a9bbd5da9c26c93127ee6272193cb06e6

Modified Files
--------------
src/backend/utils/misc/guc-file.l | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)



^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: pgsql: Straighten include order in guc-file.l
@ 2022-11-03 06:03  John Naylor <john.naylor@enterprisedb.com>
  parent: John Naylor <john.naylor@postgresql.org>
  0 siblings, 1 reply; 3+ messages in thread

From: John Naylor @ 2022-11-03 06:03 UTC (permalink / raw)
  To: John Naylor <john.naylor@postgresql.org>; +Cc: pgsql-committers@lists.postgresql.org

On Thu, Nov 3, 2022 at 12:39 PM John Naylor <john.naylor@postgresql.org>
wrote:
>
https://git.postgresql.org/pg/commitdiff/062eef3a9bbd5da9c26c93127ee6272193cb06e6

flaviventris fails on the pg_resetwal test with "initdb: error: invalid
locale settings; check LANG and LC_* environment variables", and
idiacanthus fails to start the server in another tap test. But if this
commit were at fault, surely they would fail more spectacularly?

--
John Naylor
EDB: http://www.enterprisedb.com

^ permalink  raw  reply  [nested|flat] 3+ messages in thread

* Re: pgsql: Straighten include order in guc-file.l
@ 2022-11-03 13:19  Tom Lane <tgl@sss.pgh.pa.us>
  parent: John Naylor <john.naylor@enterprisedb.com>
  0 siblings, 0 replies; 3+ messages in thread

From: Tom Lane @ 2022-11-03 13:19 UTC (permalink / raw)
  To: John Naylor <john.naylor@enterprisedb.com>; +Cc: pgsql-committers@lists.postgresql.org

John Naylor <john.naylor@enterprisedb.com> writes:
> flaviventris fails on the pg_resetwal test with "initdb: error: invalid
> locale settings; check LANG and LC_* environment variables", and
> idiacanthus fails to start the server in another tap test. But if this
> commit were at fault, surely they would fail more spectacularly?

Given the shortage of other failures, I'd write these off as noise
... unless they reproduce in future runs.  But even then, it's
very hard to blame it on this commit.

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 3+ messages in thread


end of thread, other threads:[~2022-11-03 13:19 UTC | newest]

Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-11-03 05:39 pgsql: Straighten include order in guc-file.l John Naylor <john.naylor@postgresql.org>
2022-11-03 06:03 ` John Naylor <john.naylor@enterprisedb.com>
2022-11-03 13:19   ` Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox