pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: John Naylor <john.naylor@enterprisedb.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Straighten include order in guc-file.l
Date: Thu, 03 Nov 2022 09:19:00 -0400
Message-ID: <1974929.1667481540@sss.pgh.pa.us> (raw)
In-Reply-To: <CAFBsxsHNhJGtncKKxvUqhhFKPjwXE88tBpp9zNTTHKVN07AEmw@mail.gmail.com>
References: <E1oqSwu-000Cvr-5Z@gemulon.postgresql.org>
	<CAFBsxsHNhJGtncKKxvUqhhFKPjwXE88tBpp9zNTTHKVN07AEmw@mail.gmail.com>

John Naylor <john.naylor@enterprisedb.com> writes:
> flaviventris fails on the pg_resetwal test with "initdb: error: invalid
> locale settings; check LANG and LC_* environment variables", and
> idiacanthus fails to start the server in another tap test. But if this
> commit were at fault, surely they would fail more spectacularly?

Given the shortage of other failures, I'd write these off as noise
... unless they reproduce in future runs.  But even then, it's
very hard to blame it on this commit.

			regards, tom lane





view thread (3+ messages)

Message-ID: <1974929.1667481540@sss.pgh.pa.us>
Permalink:  ../1974929.1667481540@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1974929.1667481540@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, john.naylor@enterprisedb.com
  Subject: Re: pgsql: Straighten include order in guc-file.l
  In-Reply-To: <1974929.1667481540@sss.pgh.pa.us>
  References: <E1oqSwu-000Cvr-5Z@gemulon.postgresql.org> <CAFBsxsHNhJGtncKKxvUqhhFKPjwXE88tBpp9zNTTHKVN07AEmw@mail.gmail.com> <1974929.1667481540@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox