From: Daniel Gustafsson <daniel@yesql.se>
To: Masao Fujii <masao.fujii@gmail.com>
Cc: Daniel Gustafsson <dgustafsson@postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Revert online data checksum transitions
Date: Wed, 16 Sep 2026 13:08:12 +0200
Message-ID: <1EEAFCFB-15DB-4EC1-BD49-964C799A01B2@yesql.se> (raw)
In-Reply-To: <CAHGQGwH-wHTq4xd2dedEj0niDHkezcCT_OLmMpGp9NEHW4Dvkw@mail.gmail.com>
References: <CAHGQGwH-wHTq4xd2dedEj0niDHkezcCT_OLmMpGp9NEHW4Dvkw@mail.gmail.com>
> On 16 Sep 2026, at 13:01, Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Wed, Sep 16, 2026 at 6:06 PM Daniel Gustafsson
> <dgustafsson@postgresql.org> wrote:
>>
>> Revert online data checksum transitions
>
> It's unfortunate that this feature had to be reverted...
> Anyway, thanks for all your hard work on it!!
>
>
> After the revert, the buildfarm member longfin reported the test failure [1],
> which seems to have been caused by the revert.
>
> According to longfin's server log, the test triggers the following
> assertion failure:
>
> TRAP: failed Assert("(data - start) == data_size"), File:
> "heaptuple.c", Line: 442, PID: 78459
> ...
> 2026-09-16 06:03:57.172 EDT [77693:4] LOG: client backend (PID
> 78459) was terminated by signal 6: Abort trap: 6
> 2026-09-16 06:03:57.172 EDT [77693:5] DETAIL: Failed process was
> running: SELECT count(*) > 0 AS ok FROM pg_control_checkpoint();
>
> After the revert, pg_control_checkpoint() now returns 19 columns, but its
> pg_proc.dat entry still declares 20 output columns, including
> data_page_checksum_version. This seems to trigger the assertion failure
> in heap_form_tuple().
>
> We should remove data_page_checksum_version from the pg_control_checkpoint
> entry in pg_proc.dat and reduce proargmodes from 20 output columns to 19?
Ugh, I thought I had tested everything but clearly missed this one. Will fix immediately when back from lunch.
./daniel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: daniel@yesql.se, masao.fujii@gmail.com, dgustafsson@postgresql.org, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Revert online data checksum transitions
In-Reply-To: <1EEAFCFB-15DB-4EC1-BD49-964C799A01B2@yesql.se>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox