pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Joe Conway <mail@joeconway.com>
To: Robert Haas <robertmhaas@gmail.com>
To: PostgreSQL-development <pgsql-hackers@postgreSQL.org>
Subject: Re: pgsql: Fix typos and bump catversion.
Date: Sat, 19 Nov 2022 17:10:57 -0500
Message-ID: <1e37f7d5-08a7-fbfb-da2e-b4aa5f409e01@joeconway.com> (raw)
In-Reply-To: <E1ow8l1-000my9-Ar@gemulon.postgresql.org>
References: <E1ow8l1-000my9-Ar@gemulon.postgresql.org>

On 11/18/22 16:18, Robert Haas wrote:
> Fix typos and bump catversion.
> 
> Typos reported by Álvaro Herrera and Erik Rijkers.
> 
> Catversion bump for 3d14e171e9e2236139e8976f3309a588bcc8683b was
> inadvertently omitted.
> 
> Branch
> ------
> master
> 
> Details
> -------
> https://git.postgresql.org/pg/commitdiff/2fb6154fcd769b2d4ea1226788e0ec2fc3522cb8
> 
> Modified Files
> --------------
> doc/src/sgml/ref/grant.sgml      | 2 +-
> src/bin/pg_dump/pg_dumpall.c     | 1 -
> src/include/catalog/catversion.h | 2 +-

Rishu Bagga pointed out to me offlist that this catversion bump seems 
flawed:

diff --git a/src/include/catalog/catversion.h 
b/src/include/catalog/catversion.h
index 
c6ef593207c227ce10b0c897379476b553974f67..b3a57136b755fed182b4518330e65786032db870 
100644 (file)
inline patch 1: src/include/catalog/catversion.h (+1/-1 lines) download inline-1.patch--- a/src/include/catalog/catversion.h +++ b/src/include/catalog/catversion.h @@ -57,6 +57,6 @@ */ /* yyyymmddN */ -#define CATALOG_VERSION_NO 202211121 +#define CATALOG_VERSION_NO 202211821 #endif
I think that should be 202211181, no? I am not clear on the desirable way to fix though :-/ Joe -- Joe Conway PostgreSQL Contributors Team RDS Open Source Databases Amazon Web Services: https://aws.amazon.com

view thread (5+ messages)  latest in thread

Message-ID: <1e37f7d5-08a7-fbfb-da2e-b4aa5f409e01@joeconway.com>
Permalink:  ../1e37f7d5-08a7-fbfb-da2e-b4aa5f409e01@joeconway.com/
Also on:    postgresql.org/message-id/1e37f7d5-08a7-fbfb-da2e-b4aa5f409e01@joeconway.com

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: mail@joeconway.com, robertmhaas@gmail.com, pgsql-hackers@postgreSQL.org
  Subject: Re: pgsql: Fix typos and bump catversion.
  In-Reply-To: <1e37f7d5-08a7-fbfb-da2e-b4aa5f409e01@joeconway.com>
  References: <E1ow8l1-000my9-Ar@gemulon.postgresql.org> <1e37f7d5-08a7-fbfb-da2e-b4aa5f409e01@joeconway.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox