pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Joe Conway <mail@joeconway.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Fix typos and bump catversion.
Date: Sat, 19 Nov 2022 18:01:18 -0500
Message-ID: <a50cb51d-7cf8-ea1e-1250-ce714361399e@joeconway.com> (raw)
In-Reply-To: <2655402.1668896690@sss.pgh.pa.us>
References: <E1ow8l1-000my9-Ar@gemulon.postgresql.org>
	<1e37f7d5-08a7-fbfb-da2e-b4aa5f409e01@joeconway.com>
	<20221119221618.ukkzaj3lilrrt52o@awork3.anarazel.de>
	<2655402.1668896690@sss.pgh.pa.us>

On 11/19/22 17:24, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
>> On 2022-11-19 17:10:57 -0500, Joe Conway wrote:
>>> Rishu Bagga pointed out to me offlist that this catversion bump seems
>>> flawed:
>>>  /*                         yyyymmddN */
>>> -#define CATALOG_VERSION_NO 202211121
>>> +#define CATALOG_VERSION_NO 202211821
> 
>>> I think that should be 202211181, no? I am not clear on the desirable way to
>>> fix though :-/
> 
>> I think it's fine to just update to a "normal" catversion.
> 
> Yeah, just fix it --- and the sooner the better, to avoid the risk
> that this becomes a value that someone needs to care about.


WFM, done

-- 
Joe Conway
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com






view thread (5+ messages)

Message-ID: <a50cb51d-7cf8-ea1e-1250-ce714361399e@joeconway.com>
Permalink:  ../a50cb51d-7cf8-ea1e-1250-ce714361399e@joeconway.com/
Also on:    postgresql.org/message-id/a50cb51d-7cf8-ea1e-1250-ce714361399e@joeconway.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: mail@joeconway.com, tgl@sss.pgh.pa.us, andres@anarazel.de, robertmhaas@gmail.com, pgsql-hackers@postgresql.org
  Subject: Re: pgsql: Fix typos and bump catversion.
  In-Reply-To: <a50cb51d-7cf8-ea1e-1250-ce714361399e@joeconway.com>
  References: <E1ow8l1-000my9-Ar@gemulon.postgresql.org> <1e37f7d5-08a7-fbfb-da2e-b4aa5f409e01@joeconway.com> <20221119221618.ukkzaj3lilrrt52o@awork3.anarazel.de> <2655402.1668896690@sss.pgh.pa.us> <a50cb51d-7cf8-ea1e-1250-ce714361399e@joeconway.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox