pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Fix DecodeInterval to report an error for multiple occurrences of
4+ messages / 3 participants
[nested] [flat]
Commits from this thread:
2024-04-16 768ceeeaa1 Add missing PGDLLIMPORT markings
* pgsql: Fix DecodeInterval to report an error for multiple occurrences of
@ 2009-06-01 16:55 Tom Lane <tgl@postgresql.org>
0 siblings, 0 replies; 4+ messages in thread
From: tgl@postgresql.org @ 2009-06-01 16:55 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Fix DecodeInterval to report an error for multiple occurrences of DAY, WEEK,
YEAR, DECADE, CENTURY, or MILLENIUM fields, just as it always has done for
other types of fields. The previous behavior seems to have been a hack to
avoid defining bit-positions for all these field types in DTK_M() masks,
rather than something that was really considered to be desired behavior.
But there is room in the masks for these, and we really need to tighten up
at least the behavior of DAY and YEAR fields to avoid unexpected behavior
associated with the 8.4 changes to interpret ambiguous fields based on the
interval qualifier (typmod) value. Per my example and proposed patch.
Modified Files:
--------------
pgsql/src/backend/utils/adt:
datetime.c (r1.205 -> r1.206)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/datetime.c?r1=1.205&r2=1.20...)
pgsql/src/include/utils:
datetime.h (r1.73 -> r1.74)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/utils/datetime.h?r1=1.73&r2=1.74)
^ permalink raw reply [nested|flat] 4+ messages in thread
* pgsql: Move code for backend startup to separate file
@ 2024-03-18 09:40 Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 1 reply; 4+ messages in thread
From: Heikki Linnakangas @ 2024-03-18 09:40 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Move code for backend startup to separate file
This is code that runs in the backend process after forking, rather
than postmaster. Move it out of postmaster.c for clarity.
Reviewed-by: Tristan Partin, Andres Freund
Discussion: https://www.postgresql.org/message-id/7a59b073-5b5b-151e-7ed3-8b01ff7ce9ef@iki.fi
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/05c3980e7f473ac2061dad9bbb7a9f0ede0279d9
Modified Files
--------------
src/backend/postmaster/launch_backend.c | 1 +
src/backend/postmaster/postmaster.c | 762 +------------------------------
src/backend/tcop/Makefile | 1 +
src/backend/tcop/backend_startup.c | 778 ++++++++++++++++++++++++++++++++
src/backend/tcop/meson.build | 1 +
src/include/postmaster/postmaster.h | 4 +-
src/include/tcop/backend_startup.h | 41 ++
7 files changed, 829 insertions(+), 759 deletions(-)
^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: pgsql: Move code for backend startup to separate file
@ 2024-04-15 08:24 Michael Paquier <michael@paquier.xyz>
parent: Heikki Linnakangas <heikki.linnakangas@iki.fi>
0 siblings, 1 reply; 4+ messages in thread
From: Michael Paquier @ 2024-04-15 08:24 UTC (permalink / raw)
To: Heikki Linnakangas <heikki.linnakangas@iki.fi>; +Cc: pgsql-committers@lists.postgresql.org; peter@eisentraut.org
Hi Heikki,
(Peter E. in CC.)
On Mon, Mar 18, 2024 at 09:40:36AM +0000, Heikki Linnakangas wrote:
> Move code for backend startup to separate file
>
> This is code that runs in the backend process after forking, rather
> than postmaster. Move it out of postmaster.c for clarity.
>
> Reviewed-by: Tristan Partin, Andres Freund
> Discussion: https://www.postgresql.org/message-id/7a59b073-5b5b-151e-7ed3-8b01ff7ce9ef@iki.fi
inline patch 1: src/include/postmaster/postmaster.h (+1/-0 lines) download inline-1.patch
--- a/src/include/postmaster/postmaster.h
+++ b/src/include/postmaster/postmaster.h
@@ -52,6 +52,8 @@ extern PGDLLIMPORT int postmaster_alive_fds[2];
extern PGDLLIMPORT const char *progname;
+extern bool LoadedSSL;
* Re: pgsql: Move code for backend startup to separate file
@ 2024-04-16 00:40 Michael Paquier <michael@paquier.xyz>
parent: Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 4+ messages in thread
From: Michael Paquier @ 2024-04-16 00:40 UTC (permalink / raw)
To: Heikki Linnakangas <heikki.linnakangas@iki.fi>; +Cc: pgsql-committers@lists.postgresql.org; peter@eisentraut.org
On Mon, Apr 15, 2024 at 05:24:39PM +0900, Michael Paquier wrote:
> extern PGDLLIMPORT const char *progname;
>
> +extern bool LoadedSSL;
>
> This variable is missing a PGDLLIMPORT, it seems.
>
> aafc05de1bf5 has missed a second one with MyClientSocket. Both are
> declared in postmaster.h.
For now, I've fixed these two with 768ceeeaa127.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2024-04-16 00:40 UTC | newest]
Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-06-01 16:55 pgsql: Fix DecodeInterval to report an error for multiple occurrences of Tom Lane <tgl@postgresql.org>
2024-03-18 09:40 pgsql: Move code for backend startup to separate file Heikki Linnakangas <heikki.linnakangas@iki.fi>
2024-04-15 08:24 ` Re: pgsql: Move code for backend startup to separate file Michael Paquier <michael@paquier.xyz>
2024-04-16 00:40 ` Re: pgsql: Move code for backend startup to separate file Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox