pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Heikki Linnakangas <heikki.linnakangas@iki.fi>
Cc: pgsql-committers@lists.postgresql.org
Cc: peter@eisentraut.org
Subject: Re: pgsql: Move code for backend startup to separate file
Date: Mon, 15 Apr 2024 17:24:39 +0900
Message-ID: <ZhzkRzrkKhbeQMRm@paquier.xyz> (raw)
In-Reply-To: <E1rm9Tv-004QMq-W9@gemulon.postgresql.org>
References: <E1rm9Tv-004QMq-W9@gemulon.postgresql.org>

Hi Heikki,
(Peter E. in CC.)

On Mon, Mar 18, 2024 at 09:40:36AM +0000, Heikki Linnakangas wrote:
> Move code for backend startup to separate file
> 
> This is code that runs in the backend process after forking, rather
> than postmaster. Move it out of postmaster.c for clarity.
> 
> Reviewed-by: Tristan Partin, Andres Freund
> Discussion: https://www.postgresql.org/message-id/7a59b073-5b5b-151e-7ed3-8b01ff7ce9ef@iki.fi


inline patch 1: src/include/postmaster/postmaster.h (+1/-0 lines) download inline-1.patch--- a/src/include/postmaster/postmaster.h
+++ b/src/include/postmaster/postmaster.h
@@ -52,6 +52,8 @@ extern PGDLLIMPORT int postmaster_alive_fds[2];

 extern PGDLLIMPORT const char *progname;

+extern bool LoadedSSL;


This variable is missing a PGDLLIMPORT, it seems.

aafc05de1bf5 has missed a second one with MyClientSocket.  Both are
declared in postmaster.h.

The credit goes to Peter Eisentraunt for noticing these two who has
mentioned that to me on mastodon, while I am not able to parse
correctly a set of diffs.  This stuff can be spotted with a command
like this one:
src/tools/mark_pgdllimport.pl $(git ls-files *.h)

Thanks,
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (4+ messages)  latest in thread

Message-ID: <ZhzkRzrkKhbeQMRm@paquier.xyz>
Permalink:  ../ZhzkRzrkKhbeQMRm@paquier.xyz/
Also on:    postgresql.org/message-id/ZhzkRzrkKhbeQMRm@paquier.xyz

 ·  · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, heikki.linnakangas@iki.fi, pgsql-committers@lists.postgresql.org, peter@eisentraut.org
  Subject: Re: pgsql: Move code for backend startup to separate file
  In-Reply-To: <ZhzkRzrkKhbeQMRm@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox