pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: tgl@postgresql.org
To: pgsql-committers@postgresql.org
Subject: pgsql: Make handling of INTERVAL DAY TO MINUTE and INTERVAL DAY TO
Date: Wed, 10 Jun 2009 05:05:03 +0000 (UTC)
Message-ID: <20090610050503.E8DC875331E@cvs.postgresql.org> (raw)

Log Message:
-----------
Make handling of INTERVAL DAY TO MINUTE and INTERVAL DAY TO SECOND input
more consistent with other cases, by having an unlabeled integer field
be treated as a number of minutes or seconds respectively.  These cases
are outside the spec (which insists on full "dd hh:mm" or "dd hh:mm:ss"
input respectively), so it's not much help to us in deciding what to do.
But with this change, it's uniformly the case that an unlabeled integer
will be considered as being a number of the interval's rightmost field.
The change also takes us back to the 8.3 behavior of throwing error
for certain ambiguous inputs such as INTERVAL '1 2' DAY TO MINUTE.
Per recent discussion.

Modified Files:
--------------
    pgsql/src/backend/utils/adt:
        datetime.c (r1.206 -> r1.207)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/adt/datetime.c?r1=1.206&r2=1.20...)
    pgsql/src/test/regress/expected:
        interval.out (r1.28 -> r1.29)
        (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/test/regress/expected/interval.out?r1=1.28&r2...)




view thread (2+ messages)  latest in thread

Message-ID: <20090610050503.E8DC875331E@cvs.postgresql.org>
Permalink:  ../20090610050503.E8DC875331E@cvs.postgresql.org/
Also on:    postgresql.org/message-id/20090610050503.E8DC875331E@cvs.postgresql.org

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@postgresql.org
  Subject: Re: pgsql: Make handling of INTERVAL DAY TO MINUTE and INTERVAL DAY TO
  In-Reply-To: <20090610050503.E8DC875331E@cvs.postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox