pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Code review for patch to show definition of index columns in \d
2+ messages / 2 participants
[nested] [flat]
* pgsql: Code review for patch to show definition of index columns in \d
@ 2009-07-07 16:28 Tom Lane <tgl@postgresql.org>
0 siblings, 0 replies; 2+ messages in thread
From: tgl@postgresql.org @ 2009-07-07 16:28 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Code review for patch to show definition of index columns in \d on index.
Safely schema-qualify the pg_get_indexdef call, make the query a bit
prettier in -E mode, remove useless join to pg_index, make it more obvious
that the header[] array is not overrun.
Modified Files:
--------------
pgsql/src/bin/psql:
describe.c (r1.220 -> r1.221)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/psql/describe.c?r1=1.220&r2=1.221)
^ permalink raw reply [nested|flat] 2+ messages in thread
* pgsql: Add tests for more row patterns with COPY FROM .. (ON_ERROR igno
@ 2024-03-13 05:20 Michael Paquier <michael@paquier.xyz>
0 siblings, 0 replies; 2+ messages in thread
From: Michael Paquier @ 2024-03-13 05:20 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Add tests for more row patterns with COPY FROM .. (ON_ERROR ignore)
While digging into the code of this feature, I got confused by the fact
that a line is skipped when a value cannot be converted to its expected
attribute even if the line has fewer attributes than the target
relation. The tests had a check for the case of an empty line, this
commit a couple more patterns where a line is incomplete, but skipped
because of a conversion error.
Reviewed-by: Bharath Rupireddy
Discussion: https://postgr.es/m/Ze_7kZqexdt0BiyC@paquier.xyz
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/a189ed49d6292979be1478292246be61c4563043
Modified Files
--------------
src/test/regress/expected/copy2.out | 5 +++--
src/test/regress/sql/copy2.sql | 3 +++
2 files changed, 6 insertions(+), 2 deletions(-)
^ permalink raw reply [nested|flat] 2+ messages in thread
end of thread, other threads:[~2024-03-13 05:20 UTC | newest]
Thread overview: 2+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-07-07 16:28 pgsql: Code review for patch to show definition of index columns in \d Tom Lane <tgl@postgresql.org>
2024-03-13 05:20 pgsql: Add tests for more row patterns with COPY FROM .. (ON_ERROR igno Michael Paquier <michael@paquier.xyz>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox