From: Andres Freund <andres@2ndquadrant.com>
To: Bruce Momjian <bruce@momjian.us>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Properly detect read and write errors in pg_dump/dumpall, and pg
Date: Tue, 6 May 2014 17:52:59 +0200
Message-ID: <20140506155259.GC5658@awork2.anarazel.de> (raw)
In-Reply-To: <E1WhTE9-0002Q2-U0@gemulon.postgresql.org>
References: <E1WhTE9-0002Q2-U0@gemulon.postgresql.org>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>
On 2014-05-06 00:27:21 +0000, Bruce Momjian wrote:
> Properly detect read and write errors in pg_dump/dumpall, and pg_restore
>
> Previously some I/O errors were ignored.
My compiler complains about this with:
/home/andres/src/postgresql/src/bin/pg_dump/pg_backup_tar.c: In function ‘_tarReadRaw’:
/home/andres/src/postgresql/src/bin/pg_dump/pg_backup_archiver.h:48:19: warning: passing argument 1 of ‘gzeof’ from incompatible pointer type
#define GZEOF(fh) gzeof(fh)
^
/home/andres/src/postgresql/src/bin/pg_dump/pg_backup_tar.c:561:24: note: in expansion of macro ‘GZEOF’
if (res != len && !GZEOF(fh))
^
In file included from /home/andres/src/postgresql/src/bin/pg_dump/pg_backup_archiver.h:44:0,
from /home/andres/src/postgresql/src/bin/pg_dump/pg_backup_tar.c:32:
/usr/include/zlib.h:1475:21: note: expected ‘gzFile’ but argument is of type ‘struct FILE *’
ZEXTERN int ZEXPORT gzeof OF((gzFile file));
^
You're passing fh to GZEOF instead of th->zFH if I see that correctly.
Greetings,
Andres Freund
--
Andres Freund http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andres@2ndquadrant.com, bruce@momjian.us
Subject: Re: pgsql: Properly detect read and write errors in pg_dump/dumpall, and pg
In-Reply-To: <20140506155259.GC5658@awork2.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox