pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Simon Riggs <simon@2ndQuadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Geoghegan <pg@heroku.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE.
Date: Wed, 27 May 2015 11:06:24 -0300
Message-ID: <20150527140624.GB5885@postgresql.org> (raw)
In-Reply-To: <CANP8+jKkDv7Mx=2+RLNJx+KZ1QLUtUJT-NoX=ci=H6ddT-NtUQ@mail.gmail.com>
References: <20150520215816.GI5885@postgresql.org>
	<CAM3SWZRUhr1806zsF28CVRrB=b4t8PWv8d9x29z02xTQoFDyWA@mail.gmail.com>
	<20150520220911.GK5885@postgresql.org>
	<CAM3SWZQXP3Z=iXQ_+HwoqG7417JYf6HKDTmgk-4Xt05OEL_S_Q@mail.gmail.com>
	<CAM3SWZT0Rex4CpZo+re_m2Dh7wunMNsbD-9ZSWWx=JSewW3OVg@mail.gmail.com>
	<20150521011229.GX27868@alap3.anarazel.de>
	<10660.1432171328@sss.pgh.pa.us>
	<20150521013059.GY27868@alap3.anarazel.de>
	<20150521232841.GO5885@postgresql.org>
	<CANP8+jKkDv7Mx=2+RLNJx+KZ1QLUtUJT-NoX=ci=H6ddT-NtUQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Simon Riggs wrote:

> What I think should happen is that the command tag should vary according to
> whether an INSERT or an UPDATE was performed, so we get a visible
> difference without any new tags.

The problem with doing that is that the same command might have updated
some tuples and inserted others.  Also, we build the tag before the
command is executed.

-- 
Álvaro Herrera                http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (32+ messages)  latest in thread

Message-ID: <20150527140624.GB5885@postgresql.org>
Permalink:  ../20150527140624.GB5885@postgresql.org/
Also on:    postgresql.org/message-id/20150527140624.GB5885@postgresql.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: alvherre@2ndquadrant.com, simon@2ndQuadrant.com, andres@anarazel.de, tgl@sss.pgh.pa.us, pg@heroku.com, pgsql-hackers@postgresql.org
  Subject: Re: Re: [COMMITTERS] pgsql: Add support for INSERT ... ON CONFLICT DO NOTHING/UPDATE.
  In-Reply-To: <20150527140624.GB5885@postgresql.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox