From: Stephen Frost <sfrost@snowman.net>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Improve internationalization of messages involving type names
Date: Mon, 28 Mar 2016 13:35:58 -0400
Message-ID: <20160328173558.GU3127@tamriel.snowman.net> (raw)
In-Reply-To: <E1akaul-0007ni-Rq@gemulon.postgresql.org>
References: <E1akaul-0007ni-Rq@gemulon.postgresql.org>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>
Alvaro,
* Alvaro Herrera (alvherre@alvh.no-ip.org) wrote:
> Improve internationalization of messages involving type names
>
> Change the slightly different variations of the message
> function FOO must return type BAR
> to a single wording, removing the variability in type name so that they
> all create a single translation entry; since the type name is not to be
> translated, there's no point in it being part of the message anyway.
>
> Also, change them all to use the same quoting convention, namely that
> the function name is not to be quoted but the type name is. (I'm not
> quite sure why this is so, but it's the clear majority.)
>
> Some similar messages such as "encoding conversion function FOO must ..."
> are also changed.
Buildfarm is pretty upset with this one, in particular:
http://git.postgresql.org/gitweb/?p=postgresql.git;a=blobdiff;f=src/backend/commands/event_trigger.c...
Thanks!
Stephen
Attachments:
[application/pgp-signature] signature.asc (818B, ../20160328173558.GU3127@tamriel.snowman.net/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: sfrost@snowman.net, alvherre@alvh.no-ip.org
Subject: Re: pgsql: Improve internationalization of messages involving type names
In-Reply-To: <20160328173558.GU3127@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox