pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Thomas Munro <thomas.munro@enterprisedb.com>
Cc: pgsql-committers <pgsql-committers@postgresql.org>
Subject: Re: pgsql: Add support for coordinating record typmods among parallel worke
Date: Fri, 15 Sep 2017 12:16:16 -0700
Message-ID: <20170915191616.zkaoqa34znssyfsj@alap3.anarazel.de> (raw)
In-Reply-To: <31856.1505502434@sss.pgh.pa.us>
References: <13971.1505445491@sss.pgh.pa.us>
	<CAEepm=08r6ssWnM7wOAN=omz=s9DHujsJjJY6SN_PTHayPR0hw@mail.gmail.com>
	<14932.1505447120@sss.pgh.pa.us>
	<CAEepm=13KfNVsjzvdz_u4E_3_joAWfL+k6TNaFkr-=WTT_Ou=A@mail.gmail.com>
	<CAEepm=2q2OoJ5K1Mg2_XaqjSSRbMTAmE4V7fsM5O3yTWWkb2aw@mail.gmail.com>
	<29888.1505451575@sss.pgh.pa.us>
	<CAEepm=0y78KA-UFVA=q8joA4m9tPre5y7VxMy2Jzigo+O6E6MA@mail.gmail.com>
	<21075.1505486017@sss.pgh.pa.us>
	<20170915181436.u6j27rx65giyntmk@alap3.anarazel.de>
	<31856.1505502434@sss.pgh.pa.us>
List-Unsubscribe:  <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>

On 2017-09-15 15:07:14 -0400, Tom Lane wrote:
> It's moot as long as we're not reusing workers, anyway: nothing is
> going to touch any of the record-tupdesc data before process exit.

Right - I'm ok with the end-result, I was just a bit confused about the
justification, because neither before nor after the patch it's safe to
continue executing arbitrary things in the worker. Just unsafe in
different ways. Before you could reuse a typemod, now you can use a
dangling pointer.

Greetings,

Andres Freund


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers



view thread (18+ messages)  latest in thread

Message-ID: <20170915191616.zkaoqa34znssyfsj@alap3.anarazel.de>
Permalink:  ../20170915191616.zkaoqa34znssyfsj@alap3.anarazel.de/
Also on:    postgresql.org/message-id/20170915191616.zkaoqa34znssyfsj@alap3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, thomas.munro@enterprisedb.com
  Subject: Re: pgsql: Add support for coordinating record typmods among parallel worke
  In-Reply-To: <20170915191616.zkaoqa34znssyfsj@alap3.anarazel.de>
  References: <13971.1505445491@sss.pgh.pa.us> <CAEepm=08r6ssWnM7wOAN=omz=s9DHujsJjJY6SN_PTHayPR0hw@mail.gmail.com> <14932.1505447120@sss.pgh.pa.us> <CAEepm=13KfNVsjzvdz_u4E_3_joAWfL+k6TNaFkr-=WTT_Ou=A@mail.gmail.com> <CAEepm=2q2OoJ5K1Mg2_XaqjSSRbMTAmE4V7fsM5O3yTWWkb2aw@mail.gmail.com> <29888.1505451575@sss.pgh.pa.us> <CAEepm=0y78KA-UFVA=q8joA4m9tPre5y7VxMy2Jzigo+O6E6MA@mail.gmail.com> <21075.1505486017@sss.pgh.pa.us> <20170915181436.u6j27rx65giyntmk@alap3.anarazel.de> <31856.1505502434@sss.pgh.pa.us> <20170915191616.zkaoqa34znssyfsj@alap3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox