pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Improve performance of SendRowDescriptionMessage.
Date: Fri, 13 Oct 2017 00:02:47 -0700
Message-ID: <20171013070247.GA505228@rfd.leadboat.com> (raw)
In-Reply-To: <12267.1507862660@sss.pgh.pa.us>
References: <E1e2RML-0002do-Lc@gemulon.postgresql.org>
	<307.1507819498@sss.pgh.pa.us>
	<20171012230844.ye4tnye2shysvqpk@alap3.anarazel.de>
	<20171013023536.GA492146@rfd.leadboat.com>
	<12267.1507862660@sss.pgh.pa.us>
List-Unsubscribe:  <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>

In an earlier message, I said I didn't see the problem with xlc 13.1.3.  I
withdraw that statement.  I had tested old code (commit c629324, 20 Aug),
rendering the test invalid.  xlc 13.1.3 does break commit 91d5f1a, and
removing "restrict" fixes things as it did the older version.

On Thu, Oct 12, 2017 at 10:44:20PM -0400, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > On Thu, Oct 12, 2017 at 04:08:44PM -0700, Andres Freund wrote:
> >> Noah, any chance you could force restrict to off on that animal?
> 
> > I can confirm it allows "make check" to pass.
> 
> So that leaves us with two theories:
> 
> 1. hornet's compiler contains a bug that causes it to misoptimize
> in the presence of "restrict".
> 
> 2. There's a bug in the way HEAD is applying "restrict", which happens
> not to manifest on other platforms.
> 
> While I have to agree with Andres' evident feeling that it's probably
> #1, I do not think we should dismiss #2 without inquiring a bit
> harder.  It would be really useful, I think, if we could characterize
> exactly how the RowDescription output is broken in that build.
> Noah, could you capture some of those messages somehow?

I hacked psql to call PQtrace() and ran "psql -Xc 'select true'" in the
defective configuration and in a working x64 GNU/Linux configuration.  I've
attached both PQtrace() products.

Attachments:

extraneous-xlc-aix.pqtrace (text/plain, 79B) download To backend> Msg Q To backend> "select true" To backend> Msg complete, length 17

view thread (21+ messages)  latest in thread

Message-ID: <20171013070247.GA505228@rfd.leadboat.com>
Permalink:  ../20171013070247.GA505228@rfd.leadboat.com/
Also on:    postgresql.org/message-id/20171013070247.GA505228@rfd.leadboat.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: noah@leadboat.com, tgl@sss.pgh.pa.us, andres@anarazel.de
  Subject: Re: pgsql: Improve performance of SendRowDescriptionMessage.
  In-Reply-To: <20171013070247.GA505228@rfd.leadboat.com>
  References: <E1e2RML-0002do-Lc@gemulon.postgresql.org> <307.1507819498@sss.pgh.pa.us> <20171012230844.ye4tnye2shysvqpk@alap3.anarazel.de> <20171013023536.GA492146@rfd.leadboat.com> <12267.1507862660@sss.pgh.pa.us> <20171013070247.GA505228@rfd.leadboat.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox