From: Andres Freund <andres@anarazel.de>
To: Noah Misch <noah@leadboat.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Improve performance of SendRowDescriptionMessage.
Date: Fri, 13 Oct 2017 00:32:43 -0700
Message-ID: <20171013073243.gwie26wnivefqntf@alap3.anarazel.de> (raw)
In-Reply-To: <20171013023536.GA492146@rfd.leadboat.com>
References: <E1e2RML-0002do-Lc@gemulon.postgresql.org>
<307.1507819498@sss.pgh.pa.us>
<20171012230844.ye4tnye2shysvqpk@alap3.anarazel.de>
<20171013023536.GA492146@rfd.leadboat.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>
On 2017-10-12 19:35:36 -0700, Noah Misch wrote:
> On Thu, Oct 12, 2017 at 04:08:44PM -0700, Andres Freund wrote:
> > So we've two animals (hornet, sungazer) that are:
> > #define SIZEOF_SIZE_T 8
> > #define WORDS_BIGENDIAN 1
> > #define restrict __restrict
> >
> > one compiled with xlc that fails and one with gcc that succeeds. I'm
> > hesitant to reach for that, but I wonder if there's a compiler
> > bug. Alternatively there could be some undefined behaviour here that
> > only triggers on xlc 64bit, but I'm not quite seeing it.
> >
> > Noah, any chance you could force restrict to off on that animal?
>
> I can confirm it allows "make check" to pass. Specifically, I did this
> against commit 91d5f1a:
>
> --- src/include/pg_config.h~ 2017-10-12 18:11:33.000000000 -0700
> +++ src/include/pg_config.h 2017-10-12 18:22:34.000000000 -0700
> @@ -929 +929 @@
> - #define pg_restrict __restrict
> + #define pg_restrict
> @@ -934 +934 @@
> - #define restrict __restrict
> + #define restrict
>
> I have no reason to believe this is specific to hornet's installation, so I
> recommend against altering hornet's configuration. It's too likely that the
> next xlc user will need to do the same thing.
Yea, I wasn't trying to propose that - I just thought it'd be easier to
narrow down with access to the machine than 6h cycle buildfarm
debugging.
> > Otherwise I can push a platform fix that disables it.
>
> This sounds reasonable.
I'm not getting a great vibe about the aix/xlc quality in this thread :(
Greetings,
Andres Freund
--
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, noah@leadboat.com, tgl@sss.pgh.pa.us
Subject: Re: pgsql: Improve performance of SendRowDescriptionMessage.
In-Reply-To: <20171013073243.gwie26wnivefqntf@alap3.anarazel.de>
References: <E1e2RML-0002do-Lc@gemulon.postgresql.org> <307.1507819498@sss.pgh.pa.us> <20171012230844.ye4tnye2shysvqpk@alap3.anarazel.de> <20171013023536.GA492146@rfd.leadboat.com> <20171013073243.gwie26wnivefqntf@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox