From: Andres Freund <andres@anarazel.de>
To: Magnus Hagander <magnus@hagander.net>
To: pgsql-hackers@postgresql.org
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Validate page level checksums in base backups
Date: Tue, 3 Apr 2018 10:13:56 -0700
Message-ID: <20180403171356.v4ji5sfhbc4sggij@alap3.anarazel.de> (raw)
In-Reply-To: <E1f3KUE-0003rM-6g@gemulon.postgresql.org>
References: <E1f3KUE-0003rM-6g@gemulon.postgresql.org>
On 2018-04-03 11:52:26 +0000, Magnus Hagander wrote:
> Validate page level checksums in base backups
>
> When base backups are run over the replication protocol (for example
> using pg_basebackup), verify the checksums of all data blocks if
> checksums are enabled. If checksum failures are encountered, log them
> as warnings but don't abort the backup.
>
> This becomes the default behaviour in pg_basebackup (provided checksums
> are enabled on the server), so add a switch (-k) to disable the checks
> if necessary.
>
> Author: Michael Banck
> Reviewed-By: Magnus Hagander, David Steele
> Discussion: https://postgr.es/m/20180228180856.GE13784@nighthawk.caipicrew.dd-dns.de
Hm, something isn't quite right with the test:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=pogona&dt=2018-04-03%2016%3A10%3A01
# WARNING: 6 total checksum verification failures
# pg_basebackup: checksum error occured
# '
# doesn't match '(?^s:^WARNING.*7 total checksum verification failures)'
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, magnus@hagander.net, pgsql-hackers@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Validate page level checksums in base backups
In-Reply-To: <20180403171356.v4ji5sfhbc4sggij@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox