pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers.
Date: Mon, 9 Apr 2018 15:13:54 +0900
Message-ID: <20180409061354.GD1740@paquier.xyz> (raw)
In-Reply-To: <16609.1523243109@sss.pgh.pa.us>
References: <E1f5FAB-0006LU-MB@gemulon.postgresql.org>
	<20180409010031.GA11599@paquier.xyz>
	<16609.1523243109@sss.pgh.pa.us>

On Sun, Apr 08, 2018 at 11:05:09PM -0400, Tom Lane wrote:
> Hm.  I'd tested "make -j all", but not going directly to "install".
> Does it help if you add
> 
> $(SUBDIRS:%=install-%-recurse): | submake-generated-headers
> 
> to src/Makefile?
>
> (That seems like a bit of a brute-force solution, though.  Anybody
> have a better answer?)

That takes care of the problem from the root of the directory, but when
doing the same from src/bin/ then the same issue shows up even if
src/Makefile is patched to handle install targets.

At the same time, trying to trigger a parallel install from src/backend
makes the build unhappy:
make: *** No rule to make target '../../src/common/libpgcommon_srv.a',
needed by 'postgres'.  Stop.
make: *** Waiting for unfinished jobs....

That may not be worth bothering, just mentioning.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../20180409061354.GD1740@paquier.xyz/2-signature.asc)
  download

view thread (14+ messages)  latest in thread

Message-ID: <20180409061354.GD1740@paquier.xyz>
Permalink:  ../20180409061354.GD1740@paquier.xyz/
Also on:    postgresql.org/message-id/20180409061354.GD1740@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, pgsql-hackers@postgresql.org
  Subject: Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers.
  In-Reply-To: <20180409061354.GD1740@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox