pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers.
Date: Tue, 10 Apr 2018 13:47:43 -0400
Message-ID: <12292.1523382463@sss.pgh.pa.us> (raw)
In-Reply-To: <CAOBaU_ZxAa33ZdCqSQbK4hHzbthR522M8X61nYgf6v7CTOrT0w@mail.gmail.com>
References: <E1f5FAB-0006LU-MB@gemulon.postgresql.org>
	<20180409010031.GA11599@paquier.xyz>
	<16609.1523243109@sss.pgh.pa.us>
	<20180409061354.GD1740@paquier.xyz>
	<6629.1523294509@sss.pgh.pa.us>
	<17755.1523306794@sss.pgh.pa.us>
	<CAOBaU_YH=g68opbbMk8is3jNwhoXGa8ckRSre1nx0Obe1C7i-Q@mail.gmail.com>
	<17165.1523367992@sss.pgh.pa.us>
	<CAOBaU_bMq6UNwB6HYo_LWL2kZV=T_VsY9wJW8Wum6Smnppu5MA@mail.gmail.com>
	<10009.1523379490@sss.pgh.pa.us>
	<CAOBaU_ZxAa33ZdCqSQbK4hHzbthR522M8X61nYgf6v7CTOrT0w@mail.gmail.com>

Julien Rouhaud <rjuju123@gmail.com> writes:
> On Tue, Apr 10, 2018 at 6:58 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> none of the three if-guards in the temp-install rule itself should
>> prevent this, so what is preventing it?  I don't see it.

> I just checked, and for the record the second rule (ifneq
> ($(abs_top_builddir),) is actually preventing it.

Ah-hah.  I'd misread that maze of twisty little ifdefs that
sets up abs_top_builddir et al.  Thanks for clarifying!

			regards, tom lane




view thread (14+ messages)

Message-ID: <12292.1523382463@sss.pgh.pa.us>
Permalink:  ../12292.1523382463@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/12292.1523382463@sss.pgh.pa.us

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, rjuju123@gmail.com, michael@paquier.xyz, pgsql-hackers@postgresql.org
  Subject: Re: pgsql: Merge catalog/pg_foo_fn.h headers back into pg_foo.h headers.
  In-Reply-To: <12292.1523382463@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox