pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Michael Banck <michael.banck@credativ.de>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: David Steele <david@pgmasters.net>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Validate page level checksums in base backups
Date: Wed, 11 Apr 2018 09:10:58 +0900
Message-ID: <20180411001058.GJ26769@paquier.xyz> (raw)
In-Reply-To: <500ab687-d588-020a-0e23-bfec853aac9c@2ndquadrant.com>
References: <20180404121930.GE20852@nighthawk.caipicrew.dd-dns.de>
	<20180404134732.tsxx2osvooolxy24@alvherre.pgsql>
	<CABUevEwrCF7TzAyD=4WPfTyzH+5xaFYf+-=ATW58XLi7b4dURA@mail.gmail.com>
	<20180404182247.GG20852@nighthawk.caipicrew.dd-dns.de>
	<CABUevExp8BOo3ZjEXM5xkz5P0zrjZT4_eM7QM4DLyPorDVUQUQ@mail.gmail.com>
	<20180405124113.GH20852@nighthawk.caipicrew.dd-dns.de>
	<CABUevEzZ55qgLVtMxW=hXhzjHV3oU-gChpeKtufyf_siL-rBWg@mail.gmail.com>
	<f23e92ec-118d-e6ea-0c81-876ad62a588a@2ndquadrant.com>
	<500ab687-d588-020a-0e23-bfec853aac9c@2ndquadrant.com>

On Tue, Apr 10, 2018 at 11:35:21PM +0200, Tomas Vondra wrote:
> BTW pg_verify_checksums needs the same fix.

Yes you are right here.  Just for the record: what needs to be done is
to check for PageIsNew() in scan_file() before fetching
pg_checksum_page() and after reading an individual block, which applies
even to what HEAD has for pg_verify_checksums.c.

I am adding an open item for this one.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (23+ messages)  latest in thread

Message-ID: <20180411001058.GJ26769@paquier.xyz>
Permalink:  ../20180411001058.GJ26769@paquier.xyz/
Also on:    postgresql.org/message-id/20180411001058.GJ26769@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, tomas.vondra@2ndquadrant.com, magnus@hagander.net, michael.banck@credativ.de, alvherre@alvh.no-ip.org, tgl@sss.pgh.pa.us, andres@anarazel.de, david@pgmasters.net, pgsql-hackers@postgresql.org
  Subject: Re: pgsql: Validate page level checksums in base backups
  In-Reply-To: <20180411001058.GJ26769@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox