From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Allow concurrent-safe open() and fopen() in frontend code for Wi
Date: Sat, 15 Sep 2018 07:49:39 +0900
Message-ID: <20180914224939.GA1178@paquier.xyz> (raw)
In-Reply-To: <23543.1536938575@sss.pgh.pa.us>
References: <E1g0cYN-0003oE-IE@gemulon.postgresql.org>
<23543.1536938575@sss.pgh.pa.us>
On Fri, Sep 14, 2018 at 11:22:55AM -0400, Tom Lane wrote:
> I'm surprised you didn't back-patch this --- isn't it a bug fix?
>
> A compromise might be to push it to v11 but not further.
Yes, that's clearly a bug fix from pg_ctl point of view with TAP tests.
However, I have rather cold feet about back-patching for two reasons as
this introduces a behavior change:
- The concurrency part disappears.
- Caller of open() needs to enforce text mode to strip correctly CRLF
characters.
I would be fine to get that into v11 though, as that is not released
yet. You will have to wait for a couple of days though, there is a long
week-end here away from laptops and electronic devices ;)
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20180914224939.GA1178@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Allow concurrent-safe open() and fopen() in frontend code for Wi
In-Reply-To: <20180914224939.GA1178@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox