pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Laurenz Albe <laurenz.albe@cybertec.at>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Allow concurrent-safe open() and fopen() in frontend code for Wi
Date: Thu, 20 Sep 2018 08:58:20 +0900
Message-ID: <20180919235820.GA1338@paquier.xyz> (raw)
In-Reply-To: <26882.1537372501@sss.pgh.pa.us>
References: <3883.1537200836@sss.pgh.pa.us>
	<11148.1537227504@sss.pgh.pa.us>
	<20180918001143.GG31460@paquier.xyz>
	<20180918024227.GI31460@paquier.xyz>
	<23296.1537281909@sss.pgh.pa.us>
	<71bf47219037a5e3839748eb55e4fa175b58f523.camel@cybertec.at>
	<25361.1537285137@sss.pgh.pa.us>
	<c68010480459c79f24a015096ae43b6f0bcd9854.camel@cybertec.at>
	<20180919023211.GC1650@paquier.xyz>
	<26882.1537372501@sss.pgh.pa.us>

On Wed, Sep 19, 2018 at 11:55:01AM -0400, Tom Lane wrote:
> I'm OK with this approach.  I wonder though what happens if you take
> away the "#ifdef FRONTEND" and just enforce that one or the other mode
> is selected always.  That would seem like a sensible solution rather
> than a wart to me ...

Thanks, I have pushed the solution from Laurenz to maintain pure
compatibility.  The origin of the failures reported by pg_dump actually
comes from a mismatch with pg_hba.conf in the way users and/or databases
are parsed.  I am glad that we have tests for the full range of ASCII
characters in TAP so as it is easy to detect regressions at early
stages.  We could try to manipulate more setmode calls like the one in
miscinit.c so as authentication gets the right call.  I am not sure of
other side effects though...
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../20180919235820.GA1338@paquier.xyz/2-signature.asc)
  download

view thread (24+ messages)  latest in thread

Message-ID: <20180919235820.GA1338@paquier.xyz>
Permalink:  ../20180919235820.GA1338@paquier.xyz/
Also on:    postgresql.org/message-id/20180919235820.GA1338@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, laurenz.albe@cybertec.at, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Allow concurrent-safe open() and fopen() in frontend code for Wi
  In-Reply-To: <20180919235820.GA1338@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox