pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: David Steele <david@pgmasters.net>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Make WAL segment size configurable at initdb time.
Date: Fri, 21 Sep 2018 13:53:16 +0900
Message-ID: <20180921045316.GI1338@paquier.xyz> (raw)
In-Reply-To: <20180921012354.mvkql65radrpv4gx@alap3.anarazel.de>
References: <E1duXBW-0003QB-4d@gemulon.postgresql.org>
	<68ea97d6-2ed9-f339-e57d-ab3a33caf3b1@pgmasters.net>
	<20180920235932.GD1338@paquier.xyz>
	<4b5568f5-72b7-5355-3450-973e11447569@pgmasters.net>
	<20180921012354.mvkql65radrpv4gx@alap3.anarazel.de>

On Thu, Sep 20, 2018 at 06:23:54PM -0700, Andres Freund wrote:
> 16*M*B, right?  If so, that's normal - pg_settings just reports the
> values in the underlying unit - which is XLOG_BLCKSZ, compile-time
> defaulting to 8KB. 8192 * 2048 = 16MB.  That's the same in various other
> settings.

Would it bring less confusion if we append something like "When querying
pg_settings"?  I can see David's point the current phrasing is
confusing: we don't know if this comes from pg_settings or from SHOW.
It obviously refers to the former, but one can understand that it refers
to the latter.

A second parameter in config.sgml where this formulation is used is
segment_size.
--
Michael

Attachments:

  signature.asc (application/pgp-signature, 832B) download

view thread (16+ messages)  latest in thread

Message-ID: <20180921045316.GI1338@paquier.xyz>
Permalink:  ../20180921045316.GI1338@paquier.xyz/
Also on:    postgresql.org/message-id/20180921045316.GI1338@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, andres@anarazel.de, david@pgmasters.net
  Subject: Re: pgsql: Make WAL segment size configurable at initdb time.
  In-Reply-To: <20180921045316.GI1338@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox