From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Postgres hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Remove absolete function TupleDescGetSlot().
Date: Wed, 26 Sep 2018 10:38:51 +0900
Message-ID: <20180926013851.GG1659@paquier.xyz> (raw)
In-Reply-To: <20180926001038.fh7rrhrqrwvpu43t@alap3.anarazel.de>
References: <E1g4wv3-0001Q0-8n@gemulon.postgresql.org>
<20180926000413.GC1659@paquier.xyz>
<20180926001038.fh7rrhrqrwvpu43t@alap3.anarazel.de>
On Tue, Sep 25, 2018 at 05:10:39PM -0700, Andres Freund wrote:
>> git grep TupleDescGetSlot
>> doc/src/sgml/xfunc.sgml: * user-defined SRFs that use the deprecated TupleDescGetSlot().
>> src/include/funcapi.h: * user-defined SRFs that use the deprecated TupleDescGetSlot().
>
> But here I'm less convinced. It's not entirely clear to me that the only
> real reason for this to exists actually was TupleDescGetSlot(). OTOH, I
> can't really see any proper reason to have it either.
I have not been following the recent thread about the refactoring of
TupleSlot and such very closely, but if you don't plan to use
TupleTableSlot in FuncCallContext in the future, cannot this just go
away? The function is not here anymore, so my take would be to get rid
of all things which relied on its presence.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, andres@anarazel.de, pgsql-hackers@postgresql.org
Subject: Re: pgsql: Remove absolete function TupleDescGetSlot().
In-Reply-To: <20180926013851.GG1659@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox