From: Christoph Berg <myon@debian.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Build src/port files as a library with -fPIC, and use that in li
Date: Fri, 28 Sep 2018 15:20:13 +0200
Message-ID: <20180928132013.GE26142@msg.df7cb.de> (raw)
In-Reply-To: <19404.1538140436@sss.pgh.pa.us>
References: <E1g5Y8r-0006vs-QA@gemulon.postgresql.org>
<20180928115830.GC26142@msg.df7cb.de>
<19404.1538140436@sss.pgh.pa.us>
Re: Tom Lane 2018-09-28 <19404.1538140436@sss.pgh.pa.us>
> > Is this is a problem for libpq5 users?
>
> I proposed in
> https://www.postgresql.org/message-id/19581.1538077716@sss.pgh.pa.us
>
> that we should remove pqsignal, as well as
> pg_utf_mblen
> pg_encoding_to_char
> pg_char_to_encoding
> pg_valid_server_encoding
> pg_valid_server_encoding_id
>
> from libpq's exports, on the grounds that (a) nobody should be using
> those (they're undocumented as exports), and (b) anybody who is using
> them should get them from libpgport/libpgcommon instead. Thoughts?
I'm fine with that if we say (a) should be true, and even if it is
not, (b) is an easy workaround. Bumping the libpq SONAME just because
of this seems excessive.
On the Debian side, I can simply remove the symbol from the tracking
file and the buildsystem will be happy again.
Christoph
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: myon@debian.org, tgl@sss.pgh.pa.us, pgsql-hackers@postgresql.org
Subject: Re: pgsql: Build src/port files as a library with -fPIC, and use that in li
In-Reply-To: <20180928132013.GE26142@msg.df7cb.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox