From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Set pg_class.relhassubclass for partitioned indexes
Date: Mon, 22 Oct 2018 12:12:12 +0900
Message-ID: <20181022031212.GF14282@paquier.xyz> (raw)
In-Reply-To: <82470.1540177167@sss.pgh.pa.us>
References: <E1gEPd3-0007fj-6U@gemulon.postgresql.org>
<82470.1540177167@sss.pgh.pa.us>
On Sun, Oct 21, 2018 at 10:59:27PM -0400, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> Set pg_class.relhassubclass for partitioned indexes
>
> Seems like this commit should have touched the catalogs.sgml description
> for that column, as well as the pg_class.h comment for it. Neither of
> those are worded in a way that suggests it could be set for non-table
> relations.
The pg_class.h comment looked fine for me first. How would you reword
it?
relispartition tells "True if table is a partition", which is not
actually true as it can apply to indexes. So this should be changed in
v11 as well, no?
For relhassubclass, perhaps we could do a bit more than just referring
to children... What about the following:
"True if relation has (or once had) any inheritance children or
partitions"
Here is the current formulation:
"True if table has (or once had) any inheritance children"
And this should be changed in v10~ additionally?
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Set pg_class.relhassubclass for partitioned indexes
In-Reply-To: <20181022031212.GF14282@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox