From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Include GUC's unit, if it has one, in out-of-range error message
Date: Mon, 11 Mar 2019 10:11:14 +0900
Message-ID: <20190311011114.GD1818@paquier.xyz> (raw)
In-Reply-To: <E1h33xk-0001Og-Gs@gemulon.postgresql.org>
References: <E1h33xk-0001Og-Gs@gemulon.postgresql.org>
On Sun, Mar 10, 2019 at 07:18:20PM +0000, Tom Lane wrote:
> Include GUC's unit, if it has one, in out-of-range error messages.
>
> This should reduce confusion in cases where we've applied a units
> conversion, so that the number being reported (and the quoted range
> limits) are in some other units than what the user gave in the
> setting we're rejecting.
>
> Some of the changes here assume that float GUCs can have units,
> which isn't true just yet, but will be shortly.
It does not seem to have cooled down all animals yet, whelk is
still complaining:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=whelk&dt=2019-03-11%2000%3A41%3A13
-ERROR: -Infinity is outside the valid range for parameter "geqo_selection_bias" (1.5 .. 2)
+ERROR: invalid value for parameter "geqo_selection_bias": "-infinity"
It would be nice if we could avoid an alternate output.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20190311011114.GD1818@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Include GUC's unit, if it has one, in out-of-range error message
In-Reply-To: <20190311011114.GD1818@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox