From: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
To: tgl@sss.pgh.pa.us
Cc: andrew.dunstan@2ndquadrant.com
Cc: michael@paquier.xyz
Cc: pgsql-hackers@lists.postgresql.org
Cc: laetitia.avrot@gmail.com
Subject: Re: pgsql: Add support for hyperbolic functions, as well as log10().
Date: Thu, 14 Mar 2019 12:30:00 +0900 (Tokyo Standard Time)
Message-ID: <20190314.123000.211786963.horiguchi.kyotaro@lab.ntt.co.jp> (raw)
In-Reply-To: <2503.1552533507@sss.pgh.pa.us>
References: <17820.1552514192@sss.pgh.pa.us>
<fedafa28-e63b-33f3-5d70-12ff94762a9e@2ndQuadrant.com>
<2503.1552533507@sss.pgh.pa.us>
At Wed, 13 Mar 2019 23:18:27 -0400, Tom Lane <tgl@sss.pgh.pa.us> wrote in <2503.1552533507@sss.pgh.pa.us>
tgl> Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
tgl> > Or we could possibly call the function and then turn a result of -0 into 0?
tgl>
tgl> But -0 is the correct output if the input is -0. So that approach
tgl> requires distinguishing -0 from 0, which is annoyingly difficult.
I think just turning both of -0 and +0 into +0 works, and, FWIW,
it is what is done in geo_ops.c (e.g. line_construct()) as a kind
of normalization and I think it is legit for geo_ops, but I don't
think so for fundamental functions like (d)asinh().
regards.
--
Kyotaro Horiguchi
NTT Open Source Software Center
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: horiguchi.kyotaro@lab.ntt.co.jp, tgl@sss.pgh.pa.us, andrew.dunstan@2ndquadrant.com, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org, laetitia.avrot@gmail.com
Subject: Re: pgsql: Add support for hyperbolic functions, as well as log10().
In-Reply-To: <20190314.123000.211786963.horiguchi.kyotaro@lab.ntt.co.jp>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox