From: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: laetitia.avrot@gmail.com
Subject: Re: pgsql: Add support for hyperbolic functions, as well as log10().
Date: Wed, 13 Mar 2019 23:06:51 -0400
Message-ID: <fedafa28-e63b-33f3-5d70-12ff94762a9e@2ndQuadrant.com> (raw)
In-Reply-To: <17820.1552514192@sss.pgh.pa.us>
References: <E1h3nUY-0000sM-Vf@gemulon.postgresql.org>
<20190313022159.GR13812@paquier.xyz>
<24813.1552447002@sss.pgh.pa.us>
<20190313050331.GT13812@paquier.xyz>
<17820.1552514192@sss.pgh.pa.us>
On 3/13/19 5:56 PM, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> On Tue, Mar 12, 2019 at 11:16:42PM -0400, Tom Lane wrote:
>>> I'm inclined to leave it as-is for a day or so and see if any
>>> other failures turn up, before deciding what to do about it.
>> Fine by me.
> Well, so far jacana is the only critter that's shown any problem.
>
> I don't find any of the possible solutions to be super attractive:
>
> 1. Put in an explicit special case, along the lines of
>
> if (arg1 == 0.0)
> result = arg1; /* Handle 0 and -0 explicitly */
> else
> result = asinh(arg1);
>
> Aside from being ugly, this'd mean that our regression tests weren't
> really exercising the library asinh function at all.
Or we could possibly call the function and then turn a result of -0 into 0?
cheers
andrew
--
Andrew Dunstan https://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andrew.dunstan@2ndquadrant.com, tgl@sss.pgh.pa.us, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org, laetitia.avrot@gmail.com
Subject: Re: pgsql: Add support for hyperbolic functions, as well as log10().
In-Reply-To: <fedafa28-e63b-33f3-5d70-12ff94762a9e@2ndQuadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox