From: Michael Paquier <michael@paquier.xyz>
To: Amit Langote <Langote_Amit_f8@lab.ntt.co.jp>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: [Suspect SPAM] Re: pgsql: Add pg_partition_root to display top-most parent of a partition
Date: Fri, 22 Mar 2019 13:12:25 +0900
Message-ID: <20190322041225.GS20192@paquier.xyz> (raw)
In-Reply-To: <06be11a6-fd8d-b68b-1b97-1bafb1d3185c@lab.ntt.co.jp>
References: <E1grthW-00078n-Az@gemulon.postgresql.org>
<20190322032612.GA323@alvherre.pgsql>
<20190322035538.GO20192@paquier.xyz>
<06be11a6-fd8d-b68b-1b97-1bafb1d3185c@lab.ntt.co.jp>
On Fri, Mar 22, 2019 at 01:09:23PM +0900, Amit Langote wrote:
> /* Fetch the top-most parent */
> ancestors = get_partition_ancestors(relid);
>
> Maybe, the patch should update this comment to say "Fetch the list of
> ancestors".
Perhaps so. Note that actually the list is fetched to grab the
top-most parent from it, so it sort of makes sense?
> What does "listed partition" mean? Maybe, you mean "If the input
> relation..."? How about write this as:
Input relation sounds better.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20190322041225.GS20192@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, Langote_Amit_f8@lab.ntt.co.jp, alvherre@2ndquadrant.com, pgsql-committers@lists.postgresql.org
Subject: Re: [Suspect SPAM] Re: pgsql: Add pg_partition_root to display top-most parent of a partition
In-Reply-To: <20190322041225.GS20192@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox