From: Michael Paquier <michael@paquier.xyz>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Improve stability of TAP test for synchronous replication
Date: Thu, 25 Jul 2019 07:56:51 +0900
Message-ID: <20190724225651.GA6000@paquier.xyz> (raw)
In-Reply-To: <16da29fa-d504-1380-7095-40de586dc038@2ndQuadrant.com>
References: <E1hq6VT-0002qO-AH@gemulon.postgresql.org>
<16da29fa-d504-1380-7095-40de586dc038@2ndQuadrant.com>
On Wed, Jul 24, 2019 at 02:17:14PM -0400, Andrew Dunstan wrote:
> This broke our perl coding rules:
>
> ./src/test/recovery/t/007_sync_rep.pl: Subroutine
> "start_standby_and_wait" does not end with "return" at line 33,
> column 1. See page 197 of PBP. (Severity: 5)
Fixed, thanks. Indeed I can see that pgperlcritic complains here, and
I have added a call in my pre-commit scripts for the future.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20190724225651.GA6000@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, andrew.dunstan@2ndquadrant.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Improve stability of TAP test for synchronous replication
In-Reply-To: <20190724225651.GA6000@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox