From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Shay Rojansky <roji@roji.org>
Cc: Thomas Munro <thomas.munro@gmail.com>
Cc: Andrew Gierth <andrew@tao11.riddles.org.uk>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Christoph Berg <myon@debian.org>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)
Date: Thu, 1 Aug 2019 10:19:51 -0700
Message-ID: <20190801171951.pzpp5ywdn4pgqjzc@alap3.anarazel.de> (raw)
In-Reply-To: <5560.1564668481@sss.pgh.pa.us>
References: <2643.1561508327@sss.pgh.pa.us>
<877e98syi5.fsf@news-spur.riddles.org.uk>
<CA+hUKGLZN3XHqZPN08itV4W-Nu3ndZ9zKJGSvzoWLm6AU9vz-g@mail.gmail.com>
<8736jwsdv2.fsf@news-spur.riddles.org.uk>
<17148.1561568815@sss.pgh.pa.us>
<87y31oq9g6.fsf@news-spur.riddles.org.uk>
<CA+hUKGJniUoFuC8vPJBKbMWNwvZo_wGQ8gVAZFCS068Rei9dzQ@mail.gmail.com>
<3961.1564086915@!sss.pgh.pa.us>
<CADT4RqBkkWEXr7saiFhwSptuYBAEU_e_XZxRD3o7GCSuk++Y9A@mail.gmail.com>
<5560.1564668481@sss.pgh.pa.us>
Hi,
On 2019-08-01 10:08:01 -0400, Tom Lane wrote:
> I have in fact committed that patch. It won't do anything for your
> problem with respect to existing installations that may have picked
> "localtime", but it'll at least prevent new initdb runs from picking
> that.
> Avoid choosing "localtime" or "posixrules" as TimeZone during initdb.
>
> Some platforms create a file named "localtime" in the system
> timezone directory, making it a copy or link to the active time
> zone file. If Postgres is built with --with-system-tzdata, initdb
> will see that file as an exact match to localtime(3)'s behavior,
> and it may decide that "localtime" is the most preferred spelling of
> the active zone. That's a very bad choice though, because it's
> neither informative, nor portable, nor stable if someone changes
> the system timezone setting. Extend the preference logic added by
> commit e3846a00c so that we will prefer any other zone file that
> matches localtime's behavior over "localtime".
When used and a symlink, could we resolve the symlink when determining
the timezone? When loading a timezone in the backend, not during
initdb. While that'd leave us with the instability, it'd at least would
help clients etc understand what the setting actually means?
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, roji@roji.org, thomas.munro@gmail.com, andrew@tao11.riddles.org.uk, robertmhaas@gmail.com, sfrost@snowman.net, myon@debian.org, pgsql-hackers@postgresql.org
Subject: Re: UCT (Re: pgsql: Update time zone data files to tzdata release 2019a.)
In-Reply-To: <20190801171951.pzpp5ywdn4pgqjzc@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox