From: Michael Paquier <michael@paquier.xyz>
To: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add hooks for session start and session end, take two
Date: Tue, 1 Oct 2019 14:22:45 +0900
Message-ID: <20191001052245.GH2781@paquier.xyz> (raw)
In-Reply-To: <20191001045246.GF2781@paquier.xyz>
References: <E1iF8dy-0000fc-9S@gemulon.postgresql.org>
<20191001045246.GF2781@paquier.xyz>
On Tue, Oct 01, 2019 at 01:52:46PM +0900, Michael Paquier wrote:
> This indicates that it is possible to reach GetCurrentCommandId() for
> a parallel worker in this context. It is possible to get rid of the
> problem by enforcing the following in the tests so as we have no
> parallel plans:
> SET max_parallel_workers = 0;
> SET max_parallel_workers_per_gather = 0;
> Or just use SetConfigOption as per the attached which would be a bit
> cleaner, and both could be used as a temporary solution to cool down
> the buildfarm but that does not feel completely right to me in the
> long term.
>
> Any thoughts?
Actually, it makes little sense to allow parallel workers to log their
activity in the module. So if there are no objections, I would like
to fix that by checking after IsParallelWorker() in the hooks of the
module.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add hooks for session start and session end, take two
In-Reply-To: <20191001052245.GH2781@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox