From: Michael Paquier <michael@paquier.xyz>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add hooks for session start and session end, take two
Date: Wed, 2 Oct 2019 09:25:58 +0900
Message-ID: <20191002002558.GB3130@paquier.xyz> (raw)
In-Reply-To: <20191002000228.i2vcd4maxy3nl3vp@alap3.anarazel.de>
References: <E1iF8dy-0000fc-9S@gemulon.postgresql.org>
<20191001045246.GF2781@paquier.xyz>
<18722.1569906636@sss.pgh.pa.us>
<20191001052543.GI2781@paquier.xyz>
<20191002000228.i2vcd4maxy3nl3vp@alap3.anarazel.de>
On Tue, Oct 01, 2019 at 05:02:28PM -0700, Andres Freund wrote:
> The reason for that is simply that at that point llvmjit.c's own
> shutdown hook has already shutdown parts of the JIT subsystem (which
> needs to flush profiling information to disk, for profiling to be
> useful).
Hmm. I missed the actual point. The current location for the session
end hook has been chosen because we are sure that any transaction has
been aborted properly, and we'd still be limited with a hook in
proc_exit_prepare() because of that same argument. I am just going to
revert the patch.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, andres@anarazel.de, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add hooks for session start and session end, take two
In-Reply-To: <20191002002558.GB3130@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox