From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Fujii Masao <masao.fujii@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add hooks for session start and session end, take two
Date: Wed, 2 Oct 2019 10:08:39 -0300
Message-ID: <20191002130839.GA7050@alvherre.pgsql> (raw)
In-Reply-To: <20191002051424.GC3130@paquier.xyz>
On 2019-Oct-02, Michael Paquier wrote:
> On Wed, Oct 02, 2019 at 01:27:50PM +0900, Fujii Masao wrote:
> > If only session end hook is problematic, you will commit session start
> > hook again?
>
> Sure, it would be possible to cut the apple in half here. Now my
> understanding was that both hooks were a set. What do people think?
I think that having just session start is still useful, even if I
encourage you to get session end covered, because yes they do form a set
:-) I don't think it's completely *impossible* to get session end to
work, only it needs to be run prior to any subsystem shutdown (I haven't
actually looked at the code, mind). Of course, it'll need to be clear
that it might not run in certain cases.
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@2ndquadrant.com, michael@paquier.xyz, masao.fujii@gmail.com, andres@anarazel.de, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add hooks for session start and session end, take two
In-Reply-To: <20191002130839.GA7050@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox