From: Stephen Frost <sfrost@snowman.net>
To: Christoph Berg <myon@debian.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Remove pqsignal() from libpq's official exports list.
Date: Wed, 9 Oct 2019 09:37:34 -0400
Message-ID: <20191009133734.GW6962@tamriel.snowman.net> (raw)
In-Reply-To: <20191009073354.GB30556@msg.df7cb.de>
References: <E1g5vmT-0003K1-6S@gemulon.postgresql.org>
<20191004095630.GA29119@msg.df7cb.de>
<9333.1570566305@sss.pgh.pa.us>
<20191009073354.GB30556@msg.df7cb.de>
Greetings,
* Christoph Berg (myon@debian.org) wrote:
> Re: Tom Lane 2019-10-08 <9333.1570566305@sss.pgh.pa.us>
> > Having said all that, if we conclude we can't break compatibility
> > with this legacy code quite yet, I'd be inclined to put a
> > separate, clearly-marked-as-legacy-code version of pqsignal()
> > back into libpq, using the pre-9.3 SA_RESTART semantics.
>
> That would be nice.
>
> > But I'd like some pretty well-defined sunset time for that,
> > because it'd just be trouble waiting to happen. When are
> > you going to remove 9.2 psql?
>
> Note that this change caused breakage on the wiki.postgresql.org
> infrastructure which still had an old 9.2 psql running. It wasn't
> Debian's fault that it had not been upgraded yet.
>
> But I refuse to buy the argument that I'm doing something wrong here.
> Shared libraries have SONAMEs to prevent *exactly* this kind of
> breakage. If you are removing symbols, bump the SONAME.
Yes, this is absolutely the right answer, we shouldn't be removing
symbols without an SONAME bump. If we don't want to bump the SONAME,
then don't remove the symbol. This is utterly basic proper library
maintenance and it isn't appropriate to argue that it's about "well,
your old apps shouldn't exist" because it's blatently our fault for not
bumping the SONAME, no matter how old the apps are.
Thanks,
Stephen
Attachments:
signature.asc (application/pgp-signature, 818B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: sfrost@snowman.net, myon@debian.org, tgl@sss.pgh.pa.us, pgsql-hackers@postgresql.org
Subject: Re: pgsql: Remove pqsignal() from libpq's official exports list.
In-Reply-To: <20191009133734.GW6962@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox