From: Michael Paquier <michael@paquier.xyz>
To: Amit Kapila <akapila@postgresql.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make the order of the header file includes consistent in non-bac
Date: Fri, 25 Oct 2019 12:17:02 +0900
Message-ID: <20191025031702.GD8671@paquier.xyz> (raw)
In-Reply-To: <E1iNpHW-000855-1u@gemulon.postgresql.org>
References: <E1iNpHW-000855-1u@gemulon.postgresql.org>
Hi Amit,
On Fri, Oct 25, 2019 at 02:24:50AM +0000, Amit Kapila wrote:
> Make the order of the header file includes consistent in non-backend modules.
>
> Similar to commit 7e735035f2, this commit makes the order of header file
> inclusion consistent for non-backend modules.
>
> In passing, fix the case where we were using angle brackets (<>) for the
> local module includes instead of quotes ("").
locust has just reported a build failure here:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=locust&dt=2019-10-25%2002%3A58%3A55
And the cause is visibly this portion of the commit:
inline patch 1: src/interfaces/ecpg/pgtypeslib/dt_common.c (+1/-2 lines) download inline-1.patch--- a/src/interfaces/ecpg/pgtypeslib/dt_common.c+++ b/src/interfaces/ecpg/pgtypeslib/dt_common.c@@ -7,9 +7,9 @@
#include <math.h>
#include "common/string.h"
-#include "pgtypeslib_extern.h"
#include "dt.h"
#include "pgtypes_timestamp.h"
+#include "pgtypeslib_extern.h" --Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, akapila@postgresql.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make the order of the header file includes consistent in non-bac
In-Reply-To: <20191025031702.GD8671@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox