From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Emit parameter values during query bind/execute errors
Date: Thu, 12 Dec 2019 13:47:20 -0300
Message-ID: <20191212164720.GA27169@alvherre.pgsql> (raw)
In-Reply-To: <3562.1576161217@sss.pgh.pa.us>
On 2019-Dec-12, Tom Lane wrote:
> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > Emit parameter values during query bind/execute errors
>
> (Some of?) the Windows buildfarm critters don't like the test
> case you added. I speculate that the test pattern is neglecting
> to allow for Windows-style newlines.
Hmm, the affected ones (jacana and fairywren only AFAICS) seem to be
gcc-based, which presumably work differently than the msvc-based in how
newlines are interpreted in the test script. I pushed an attempted
blind fix.
I *hope* that those two are not the only Windows ones running the
pgbench tap test!
--
Álvaro Herrera https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Emit parameter values during query bind/execute errors
In-Reply-To: <20191212164720.GA27169@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox