pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Christoph Berg <myon@debian.org>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
Date: Thu, 9 Jan 2020 15:59:00 +0100
Message-ID: <20200109145900.GF4192@msg.df7cb.de> (raw)
In-Reply-To: <CA+TgmoZC_6z3d5+6n1GVfy898uoBHMPPJU4-nAQLG5ZkaEyqdQ@mail.gmail.com>
References: <E1in6ft-0004zR-6l@gemulon.postgresql.org>
	<20200103110128.GA28967@msg.df7cb.de>
	<13708.1578059577@sss.pgh.pa.us>
	<25771.1578249042@sss.pgh.pa.us>
	<20200106105608.GB18560@msg.df7cb.de>
	<3764.1578323719@sss.pgh.pa.us>
	<20200106191303.GA3975@msg.df7cb.de>
	<19973.1578351988@sss.pgh.pa.us>
	<28773.1578436137@sss.pgh.pa.us>
	<CA+TgmoZC_6z3d5+6n1GVfy898uoBHMPPJU4-nAQLG5ZkaEyqdQ@mail.gmail.com>

Re: Robert Haas 2020-01-09 <CA+TgmoZC_6z3d5+6n1GVfy898uoBHMPPJU4-nAQLG5ZkaEyqdQ@mail.gmail.com>
> > So that raises the question: why does xenial's version of libedit
> > not match either its documentation or the distributed source code?
> > Because it doesn't.
> 
> The level of effort you've put into this is extremely impressive, but
> I can't shake the feeling that you're going to keep finding issues in
> the test setup, the operating system, or the upstream libraries,
> rather than bugs in PostgreSQL. Maybe this is all just one-time
> stabilization effort, but...

Fwiw if libedit in xenial is Just Broken and fixing the tests would
just codify the brokenness without adding any value, I'll just disable
that test in that particular build. It looks like setting
with_readline=no on the make command line should work.

Christoph

view thread (64+ messages)  latest in thread

Message-ID: <20200109145900.GF4192@msg.df7cb.de>
Permalink:  ../20200109145900.GF4192@msg.df7cb.de/
Also on:    postgresql.org/message-id/20200109145900.GF4192@msg.df7cb.de

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: myon@debian.org, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, andres@anarazel.de, amit.kapila16@gmail.com, pgsql-hackers@postgresql.org
  Subject: Re: pgsql: Add basic TAP tests for psql's tab-completion logic.
  In-Reply-To: <20200109145900.GF4192@msg.df7cb.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox