From: Andres Freund <andres@anarazel.de>
To: David Steele <david@pgmasters.net>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Date: Fri, 6 Mar 2020 11:16:55 -0800
Message-ID: <20200306191655.gm7hjex5c7znmomr@alap3.anarazel.de> (raw)
In-Reply-To: <1cf30561-7dad-dc6e-9fc3-5c456948cfeb@pgmasters.net>
References: <E1j9ioh-0005Kn-4O@gemulon.postgresql.org>
<1cf30561-7dad-dc6e-9fc3-5c456948cfeb@pgmasters.net>
Hi,
On 2020-03-05 12:51:50 -0500, David Steele wrote:
> On 3/5/20 12:13 AM, Michael Paquier wrote:
> > Avoid -Wconversion warnings when using checksum_impl.h
> >
> > This does not matter much when compiling Postgres proper as many
> > warnings exist when enabling this compilation flag, but it can be
> > annoying for external modules willing to use both.
>
> Looks like you changed 65535 -> 65536 before commit. I checked the original
> patch and it has 65535.
I gotta say, that's something that just shouldn't happen.
Greetings,
Andres Freund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: andres@anarazel.de, david@pgmasters.net, michael@paquier.xyz, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
In-Reply-To: <20200306191655.gm7hjex5c7znmomr@alap3.anarazel.de>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox