pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Alvaro Herrera <alvherre@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Use perl warnings pragma consistently
Date: Mon, 13 Apr 2020 17:49:52 -0400
Message-ID: <20200413214952.GA22285@alvherre.pgsql> (raw)
In-Reply-To: <28260.1586813631@sss.pgh.pa.us>

On 2020-Apr-13, Tom Lane wrote:

> Andrew Dunstan <andrew@dunslane.net> writes:
> > Use perl warnings pragma consistently
> 
> This seems to have broken something or other, as I now get a bunch of
> warnings while building the docs:
> 
> ...
> Use of uninitialized value within %feature_packages in concatenation (.) or string at ./mk_feature_tables.pl line 57, <$feat> line 522.
> Use of uninitialized value within %feature_packages in concatenation (.) or string at ./mk_feature_tables.pl line 57, <$feat> line 524.
> Use of uninitialized value within %feature_packages in concatenation (.) or string at ./mk_feature_tables.pl line 57, <$feat> line 526.
> Use of uninitialized value within %feature_packages in concatenation (.) or string at ./mk_feature_tables.pl line 57, <$feat> line 528.
> Use of uninitialized value within %feature_packages in concatenation (.) or string at ./mk_feature_tables.pl line 57, <$feat> line 529.

This should fix it.

-- 
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Attachments:

defined.patch (text/x-diff, 550B) download
diff --git a/doc/src/sgml/mk_feature_tables.pl b/doc/src/sgml/mk_feature_tables.pl
index ee158cb196..a9dfebfbb3 100644
--- a/doc/src/sgml/mk_feature_tables.pl
+++ b/doc/src/sgml/mk_feature_tables.pl
@@ -54,7 +54,9 @@ while (<$feat>)
 	{
 		print "  <entry>$feature_id</entry>\n";
 	}
-	print "  <entry>" . $feature_packages{$feature_id} . "</entry>\n";
+	print "  <entry>",
+		  defined($feature_packages{$feature_id}) ? $feature_packages{$feature_id} : "",
+		  "</entry>\n";
 	if ($subfeature_id)
 	{
 		print "  <entry>$subfeature_name</entry>\n";

view thread (4+ messages)  latest in thread

Message-ID: <20200413214952.GA22285@alvherre.pgsql>
Permalink:  ../20200413214952.GA22285@alvherre.pgsql/
Also on:    postgresql.org/message-id/20200413214952.GA22285@alvherre.pgsql

copy link · copy postgr.es · copy git am

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: alvherre@2ndquadrant.com, tgl@sss.pgh.pa.us, andrew@dunslane.net, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Use perl warnings pragma consistently
  In-Reply-To: <20200413214952.GA22285@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox