From: Bruce Momjian <bruce@momjian.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
Date: Thu, 12 Nov 2020 18:15:51 -0500
Message-ID: <20201112231551.GF4506@momjian.us> (raw)
In-Reply-To: <20201112202900.GA28098@alvherre.pgsql>
References: <E1kdIy8-0005Xl-AT@gemulon.postgresql.org>
<20201112202900.GA28098@alvherre.pgsql>
On Thu, Nov 12, 2020 at 05:29:00PM -0300, Álvaro Herrera wrote:
> On 2020-Nov-12, Bruce Momjian wrote:
>
> > doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
> >
> > These files are in compiled directories and install directories.
>
> I think this patch is wrong, because in the install tree the files are in
> the server/ subdir. It should read:
>
> The <acronym>OID</acronym>s of the built-in data types are defined in
> the file <filename>include/catalog/pg_type_d.h</filename> in the
> compiled source directory, and in
> <filename>include/server/catalog/pg_type_d.h</filename> in the install
> directory.
>
> That said, if the user is doing a VPATH build, then "compiled source
> directory" is a confusing way to say "the build directory", and I don't
> think it's an important location anyway, first because it's really a
> throwaway directory, and second it's not even there in a packaged
> installation; users just care about the *installed* file, don't they?
> So I suggest to rip that part out, and leave just:
>
> The <acronym>OID</acronym>s of the built-in data types are defined in
> the file <filename>include/server/catalog/pg_type_d.h</filename> in the
> install directory.
OK, how is this followup patch?
--
Bruce Momjian <bruce@momjian.us> https://momjian.us
EnterpriseDB https://enterprisedb.com
The usefulness of a cup is in its emptiness, Bruce Lee
Attachments:pg_type-v2.diff (text/x-diff, 721B) downloaddiff --git a/doc/src/sgml/libpq.sgml b/doc/src/sgml/libpq.sgmlindex 73c6a6ea4d..9d4b6ab4a8 100644--- a/doc/src/sgml/libpq.sgml+++ b/doc/src/sgml/libpq.sgml@@ -3666,8 +3666,8 @@ Oid PQftype(const PGresult *res,
You can query the system table <literal>pg_type</literal> to
obtain the names and properties of the various data types. The
<acronym>OID</acronym>s of the built-in data types are defined
- in the file <filename>include/catalog/pg_type_d.h</filename>- in the compiled source directory and install directory.+ in the file <filename>include/server/catalog/pg_type_d.h</filename>+ in the install directory.
</para>
</listitem>
</varlistentry>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: bruce@momjian.us, alvherre@alvh.no-ip.org, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: doc: clarify where to find pg_type_d.h (PG 11+) and pg_type.h
In-Reply-To: <20201112231551.GF4506@momjian.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox