pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Dilip Kumar <dilipbalaut@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Document XLOG_INCLUDE_XID a little better
Date: Sat, 2 Oct 2021 11:40:10 -0300
Message-ID: <202110021440.hepk6kcgtjzi@alvherre.pgsql> (raw)
In-Reply-To: <CAFiTN-ssWF6X7mGrjpvQ+yg7FbPFfGBBfb4npc8ZL_J8yKyF=w@mail.gmail.com>

On 2021-Oct-02, Dilip Kumar wrote:

> I have written two patches, Approach1 is as you described using a
> static boolean and Approach2 as a local variable to XLogAssembleRecord
> as described by Amit, attached both of them for your reference.
> IMHO, either of these approaches looks cleaner.

Thanks!  I haven't read these patches carefully, but I think the
variable is about assigning the *subxid*, not the topxid.  Amit can
confirm ...


-- 
Álvaro Herrera           39°49'30"S 73°17'W  —  https://www.EnterpriseDB.com/
"Aprender sin pensar es inútil; pensar sin aprender, peligroso" (Confucio)





view thread (30+ messages)  latest in thread

Message-ID: <202110021440.hepk6kcgtjzi@alvherre.pgsql>
Permalink:  ../202110021440.hepk6kcgtjzi@alvherre.pgsql/
Also on:    postgresql.org/message-id/202110021440.hepk6kcgtjzi@alvherre.pgsql

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, dilipbalaut@gmail.com, amit.kapila16@gmail.com, robertmhaas@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Document XLOG_INCLUDE_XID a little better
  In-Reply-To: <202110021440.hepk6kcgtjzi@alvherre.pgsql>
  References: <CAFiTN-ssWF6X7mGrjpvQ+yg7FbPFfGBBfb4npc8ZL_J8yKyF=w@mail.gmail.com> <202110021440.hepk6kcgtjzi@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox