pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.
Date: Mon, 18 Oct 2021 11:23:48 -0300
Message-ID: <202110181423.cmd34pruwlry@alvherre.pgsql> (raw)
In-Reply-To: <e1798960-6c44-8527-527b-d1680cbd1c22@dunslane.net>

On 2021-Oct-17, Andrew Dunstan wrote:

> +sub find_built_program
> +{
> +	my $program = shift;
> +	my $path;
> +
> +	if (defined $ENV{MSBUILDDIR})
> +	{
> +		# vcregress.pl sets MSBUILDDIR which is the root of all the build dirs
> +		my $wanted = sub { $_ eq "$program.exe" && $path = $File::Find::name;};
> +		File::Find::find($wanted,$ENV{MSBUILDDIR});
> +	}

Hmm, it seems weird to have to use File::Find when we already know where
the program is, right?  I mean, per your previous patch, we know that
the program is in $MSBUILDDIR/libpq_pipeline/libpq_pipeline.exe, so why
don't we make this one be

if (defined $ENV{MSBUILDDIR})
{
	return $ENV{MSBUILDDIR} . "$program/$program.exe";
}

?

I noticed that drongo is still red, and reporting that no tests are
being run.  While this makes sense (because the list of tests is
obtained by running libpq_pipeline), I am surprised that this isn't
reported as such.  I would have expected it to die with an error message
starting with "oops: " ... did run_command() fail to return stderr?

... oh, run_command() seems a bit too optimistic: it doesn't check
whether IPC::Run::run() failed.  I think that's worth fixing
independently.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
Subversion to GIT: the shortest path to happiness I've ever heard of
                                                (Alexey Klyukin)





view thread (15+ messages)  latest in thread

Message-ID: <202110181423.cmd34pruwlry@alvherre.pgsql>
Permalink:  ../202110181423.cmd34pruwlry@alvherre.pgsql/
Also on:    postgresql.org/message-id/202110181423.cmd34pruwlry@alvherre.pgsql

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: alvherre@alvh.no-ip.org, andrew@dunslane.net, andres@anarazel.de
  Subject: Re: pgsql: Reference test binary using TESTDIR in 001_libpq_pipeline.pl.
  In-Reply-To: <202110181423.cmd34pruwlry@alvherre.pgsql>
  References: <e1798960-6c44-8527-527b-d1680cbd1c22@dunslane.net> <202110181423.cmd34pruwlry@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox