pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Peter Eisentraut <peter@eisentraut.org>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: pgcrypto: Remove non-OpenSSL support
Date: Sat, 6 Nov 2021 15:04:10 -0700
Message-ID: <20211106220410.th5iyb4mmqyz5hk5@alap3.anarazel.de> (raw)
In-Reply-To: <E1miyyh-0007VL-Ba@gemulon.postgresql.org>
References: <E1miyyh-0007VL-Ba@gemulon.postgresql.org>

Hi,

On 2021-11-05 13:09:55 +0000, Peter Eisentraut wrote:
> pgcrypto: Remove non-OpenSSL support
> 
> pgcrypto had internal implementations of some encryption algorithms,
> as an alternative to calling out to OpenSSL.  These were rarely used,
> since most production installations are built with OpenSSL.  Moreover,
> maintaining parallel code paths makes the code more complex and
> difficult to maintain.
> 
> This patch removes these internal implementations.  Now, pgcrypto is
> only built if OpenSSL support is configured.

This appears to have broken msvc pgcrypto being tested with msvc. I think
that's because pgcrypto is still listed in the "base" @contrib_excludes and
thus just isn't getting built anymore, now that the special-case build rule is
gone?

Greetings,

Andres Freund





view thread (8+ messages)  latest in thread

Message-ID: <20211106220410.th5iyb4mmqyz5hk5@alap3.anarazel.de>
Permalink:  ../20211106220410.th5iyb4mmqyz5hk5@alap3.anarazel.de/
Also on:    postgresql.org/message-id/20211106220410.th5iyb4mmqyz5hk5@alap3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, peter@eisentraut.org
  Subject: Re: pgsql: pgcrypto: Remove non-OpenSSL support
  In-Reply-To: <20211106220410.th5iyb4mmqyz5hk5@alap3.anarazel.de>
  References: <E1miyyh-0007VL-Ba@gemulon.postgresql.org> <20211106220410.th5iyb4mmqyz5hk5@alap3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox