From: Stephen Frost <sfrost@snowman.net>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Fix headerscheck failure in replication/worker_internal.h
Date: Tue, 16 Nov 2021 12:14:31 -0500
Message-ID: <20211116171430.GI26257@tamriel.snowman.net> (raw)
In-Reply-To: <202111161709.u3pbx5lxdimt@alvherre.pgsql>
References: <E1mn1OI-0007WG-H9@gemulon.postgresql.org>
<202111161709.u3pbx5lxdimt@alvherre.pgsql>
Greetings,
* Alvaro Herrera (alvherre@alvh.no-ip.org) wrote:
> On 2021-Nov-16, Alvaro Herrera wrote:
>
> > Fix headerscheck failure in replication/worker_internal.h
>
> The other failure is in src/include/libpq/be-gssapi-common.h:
>
> In file included from /tmp/headerscheck.a6f0um/test.c:2:
> ./src/include/libpq/be-gssapi-common.h:20:10: fatal error: gssapi/gssapi.h: No existe el fichero o el directorio
> 20 | #include <gssapi/gssapi.h>
> | ^~~~~~~~~~~~~~~~~
> compilation terminated.
>
> One possible solution for this one is to add an exclusion in
> headerscheck (and cpluspluscheck?); the other possible solution seems to
> be to wrap the whole contents of the file in "#ifdef ENABLE_GSS". I
> think the latter is roughly the approach used for OpenSSL inclusions.
Short answer is yes, inclusion of be-gssapi-common.h is typically
wrapped in a #ifdef, see src/backend/libpq/auth.c
Thanks,
Stephen
Attachments:
[application/pgp-signature] signature.asc (818B, ../20211116171430.GI26257@tamriel.snowman.net/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: sfrost@snowman.net, alvherre@alvh.no-ip.org, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Fix headerscheck failure in replication/worker_internal.h
In-Reply-To: <20211116171430.GI26257@tamriel.snowman.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox