From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Stephen Frost <sfrost@snowman.net>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Fix headerscheck failure in replication/worker_internal.h
Date: Tue, 16 Nov 2021 15:16:45 -0300
Message-ID: <202111161816.bncq4ckt6ahl@alvherre.pgsql> (raw)
In-Reply-To: <CAOuzzgqm1KoJoDNp2o1eFUYNe41ucR=-Hp2+0tv-JJJLY+Yshw@mail.gmail.com>
On 2021-Nov-16, Stephen Frost wrote:
> Not against possibly changing that but I don’t get the point of including
> be-gssapi-common.h if it’s not enabled in the build and typically if GSSAPI
> is possible and the reason for including be-gssapi-common.h then there’s
> other things that need to be under a ifdef, again, as in auth.c
BTW, this is exactly why my first suggestion was to add an exclusion
rule to headerscheck so that be-gssapi-common.h is not verified by that
script. After re-reading your response, that looks like a reasonable
answer too.
--
Álvaro Herrera Valdivia, Chile — https://www.EnterpriseDB.com/
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: alvherre@alvh.no-ip.org, sfrost@snowman.net, pgsql-hackers@lists.postgresql.org
Subject: Re: pgsql: Fix headerscheck failure in replication/worker_internal.h
In-Reply-To: <202111161816.bncq4ckt6ahl@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox