pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Require version 0.98 of Test::More for TAP tests
Date: Sat, 20 Nov 2021 17:10:26 -0800
Message-ID: <20211121011026.GB1362012@rfd.leadboat.com> (raw)
In-Reply-To: <3371085.1637455802@sss.pgh.pa.us>
References: <E1moZHS-0002Cu-Ei@gemulon.postgresql.org>
	<3369543.1637454364@sss.pgh.pa.us>
	<3369927.1637454743@sss.pgh.pa.us>
	<20211121003630.GA1362012@rfd.leadboat.com>
	<3371085.1637455802@sss.pgh.pa.us>

On Sat, Nov 20, 2021 at 07:50:02PM -0500, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > Yep.  wrasse sets PERL to a manually-installed Perl, but PROVE still uses an
> > old Perl.  I'll fix that somehow.
> 
> A quick workaround is to set PROVE in the animal's config_env, but
> I don't think that's ideal, because configure then skips module
> presence tests:
> 
>   # Check for necessary modules, unless user has specified the "prove" to use;
>   # in that case it's her responsibility to have a working configuration.
>   # (prove might be part of a different Perl installation than perl, eg on
>   # MSys, so the result of AX_PROG_PERL_MODULES could be irrelevant anyway.)

The skip would be unnecessary if configure just tested whether $PROVE can run
a test requiring the module.  We're testing $PERL, but we're actually
indifferent to $PERL's Test::More.

> What I'm inclined to do is temporarily push `dirname $PERL` onto the front
> of PATH while running
> 
>   PGAC_PATH_PROGS(PROVE, prove)

Adding to PATH, even briefly, is way too brazen.  You'd need to be sure that
PATH is never searched for anything other than "prove", which is hard to
ensure in a shell script.  Explicitly testing $(dirname "$PERL")/prove could
be okay.  It feels inappropriately magical to me, but perhaps it's the right
thing.  I'd be -1 on a back-patch and -0.7 for HEAD.





view thread (17+ messages)  latest in thread

Message-ID: <20211121011026.GB1362012@rfd.leadboat.com>
Permalink:  ../20211121011026.GB1362012@rfd.leadboat.com/
Also on:    postgresql.org/message-id/20211121011026.GB1362012@rfd.leadboat.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: noah@leadboat.com, tgl@sss.pgh.pa.us, andrew@dunslane.net, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Require version 0.98 of Test::More for TAP tests
  In-Reply-To: <20211121011026.GB1362012@rfd.leadboat.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox